Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3136 - ThisExpr isn't resolved correctly when it is in the scope of an ObjectCreationExpr #3137

Merged
merged 6 commits into from Mar 20, 2021

Conversation

deadlocklogic
Copy link
Contributor

Fixes #3136

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #3137 (4de728d) into master (b4a6c81) will increase coverage by 0.011%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #3137       +/-   ##
=============================================
+ Coverage   53.122%   53.134%   +0.011%     
=============================================
  Files          450       450               
  Lines        25108     25108               
  Branches      3784      3786        +2     
=============================================
+ Hits         13338     13341        +3     
+ Misses       10683     10681        -2     
+ Partials      1087      1086        -1     
Flag Coverage Δ
AlsoSlowTests 53.134% <ø> (+0.011%) ⬆️
javaparser-core 53.134% <ø> (+0.011%) ⬆️
jdk-10 53.122% <ø> (+0.003%) ⬆️
jdk-11 53.134% <ø> (?)
jdk-12 53.134% <ø> (?)
jdk-13 53.134% <ø> (?)
jdk-14 53.134% <ø> (+0.011%) ⬆️
jdk-15 53.134% <ø> (?)
jdk-8 53.132% <ø> (?)
jdk-9 53.134% <ø> (?)
macos-latest 53.122% <ø> (?)
ubuntu-latest 53.122% <ø> (ø)
windows-latest 53.122% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/com/github/javaparser/utils/LineSeparator.java 84.615% <0.000%> (+1.538%) ⬆️
...urces/com/github/javaparser/TokenMgrException.java 74.358% <0.000%> (+5.128%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a6c81...4de728d. Read the comment docs.

@MysterAitch MysterAitch changed the title Fixed #3136 Fixed #3136 - ThisExpr isn't resolved correctly when it is in the scope of an ObjectCreationExpr Mar 7, 2021
@MysterAitch MysterAitch added this to the next release milestone Mar 20, 2021
@MysterAitch MysterAitch added the PR: Fixed A PR that offers a fix or correction label Mar 20, 2021
@MysterAitch MysterAitch merged commit d559a0f into javaparser:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThisExpr isn't resolved correctly when it is in the scope of an ObjectCreationExpr
2 participants