Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 263: lost orphan comments before initializer block #338

Closed
wants to merge 4 commits into from
Closed

Fix for issue 263: lost orphan comments before initializer block #338

wants to merge 4 commits into from

Conversation

matozoid
Copy link
Contributor

@matozoid matozoid commented Jul 6, 2016

This does fix the issue, but I'm really unhappy with it. Adding that line feels completely random, and the result causes the comments to move one line down. Comments?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 61.184% when pulling 30e136b on matozoid:issue_263 into 43ac5e6 on javaparser:master.

# Conflicts:
#	javaparser-testing/src/test/resources/com/github/javaparser/bdd/dumping_scenarios.story
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 61.067% when pulling 4d8ef88 on matozoid:issue_263 into 51a5cb6 on javaparser:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.788% when pulling a4d586b on matozoid:issue_263 into d378a67 on javaparser:master.

@matozoid matozoid added Need more input Issue which need more discussion about the design/direction before implementing it fully. PR: bug fix labels Jul 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 60.41% when pulling 60784ee on matozoid:issue_263 into 174c255 on javaparser:master.

@matozoid
Copy link
Contributor Author

matozoid commented Sep 4, 2016

This is not the correct solution.

@matozoid matozoid closed this Sep 4, 2016
@matozoid matozoid removed the Need more input Issue which need more discussion about the design/direction before implementing it fully. label Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants