Fix: #3725 JavaParserFacade var type in for-each loop cannot be resolved #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be resolved
Before this fix it was not possible to resolve the type of the variable
used in a for-each loop when the type of the variable was defined as `var`.
This was because the original code only took care of the `var with
initializer` case (e.g. `var i = "hello";`).
The fix now also covers the usage of a `var` in a for-each loop, e.g.
as in `for (var s: names) {...}`. The expression at the right side
of the `:` must either be an array or an Iterable.
The bug was originally reported in
javaparser#3725
Codecov Report
@@ Coverage Diff @@
## master #3768 +/- ##
===============================================
+ Coverage 57.434% 57.440% +0.006%
- Complexity 2680 2683 +3
===============================================
Files 635 635
Lines 33722 33741 +19
Branches 5824 5830 +6
===============================================
+ Hits 19368 19381 +13
- Misses 12283 12285 +2
- Partials 2071 2075 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thank you for this contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix it was not possible to resolve the type of the variable used in a for-each loop when the type of the variable was defined as
var. This was because the original code only took care of thevar with initializercase (e.g.var i = "hello";).The fix now also covers the usage of a
varin a for-each loop, e.g. as infor (var s: names) {...}. The expression at the right side of the:must either be an array or an Iterable.The bug was originally reported in #3725
Fixes #3725 .