Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing, in test classes, the initialization of the lexical preserva… #3779

Merged
merged 1 commit into from Dec 8, 2022

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Dec 8, 2022

…tion printer

@jlerbsc jlerbsc merged commit b4a28c4 into javaparser:master Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3779 (b7375c9) into master (498e91f) will decrease coverage by 0.002%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3779       +/-   ##
===============================================
- Coverage     57.448%   57.445%   -0.003%     
  Complexity      2542      2542               
===============================================
  Files            636       636               
  Lines          33811     33811               
  Branches        5841      5841               
===============================================
- Hits           19424     19423        -1     
  Misses         12307     12307               
- Partials        2080      2081        +1     
Flag Coverage Δ
AlsoSlowTests 57.445% <ø> (-0.003%) ⬇️
javaparser-core 51.953% <ø> (-0.008%) ⬇️
javaparser-symbol-solver 36.650% <ø> (+0.002%) ⬆️
jdk-10 57.438% <ø> (+0.008%) ⬆️
jdk-11 57.435% <ø> (-0.009%) ⬇️
jdk-12 57.441% <ø> (+0.008%) ⬆️
jdk-13 57.441% <ø> (+0.011%) ⬆️
jdk-14 57.441% <ø> (+0.008%) ⬆️
jdk-15 57.441% <ø> (+0.011%) ⬆️
jdk-16 57.441% <ø> (+0.008%) ⬆️
jdk-8 57.443% <ø> (ø)
jdk-9 57.441% <ø> (-0.003%) ⬇️
macos-latest 57.433% <ø> (-0.006%) ⬇️
ubuntu-latest 57.431% <ø> (?)
windows-latest 57.425% <ø> (-0.006%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../lexicalpreservation/LexicalPreservingPrinter.java 70.940% <0.000%> (-0.285%) ⬇️
...ava/com/github/javaparser/ParserConfiguration.java 89.552% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498e91f...b7375c9. Read the comment docs.

@jlerbsc jlerbsc added this to the next release milestone Dec 8, 2022
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant