Refactoring context (WIP) #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TypeExtractor class so as not to have to systematically declare a ReflectionTypeSolver, adapt unit tests accordingly and classes that do not support LazyType
…den by using TypeSolver
…den by using TypeSolver (2)
…on. The goal of removing dependencies with the javaparser-symbol-solver-core module is to allow the TypeExtractor class to be migrated to the JP core module with the ultimate goal of letting nodes create their own context.
…flexionClassDeclaration (symbol solver module)
… SymbolSolver class because not only is it more logical for this functionality to be implemented in SymbolSolver, but also this modification makes it possible to remove class dependencies with the JavaParserFacade class which is specific to the SymbolSolver module.
jlerbsc
added
the
PR: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of a larger change to better integrate the JP core module and the SymbolSolver module. The first objective of this PR is to support the creation of contexts no longer by the JavaParserFactory class but by the expressions themselves. It therefore introduces changes that will cause a break in the APIs used by project users.