Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested records #3814

Merged
merged 1 commit into from Dec 26, 2022
Merged

Handle nested records #3814

merged 1 commit into from Dec 26, 2022

Conversation

mernst
Copy link
Contributor

@mernst mernst commented Dec 24, 2022

This pull request handles nested records.
It also updates some outdated comments about the Java grammar.

@jlerbsc
Copy link
Collaborator

jlerbsc commented Dec 26, 2022

Can you give us the reference in the Java specification?

@mernst
Copy link
Contributor Author

mernst commented Dec 26, 2022

@jlerbsc The reference in the Java specification is in the pull request: https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.10 .

At https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.10.2 you can see that a RecordBody can contain anything a class body can, and classes (and records, enums, etc.) can be nested within classes.

@jlerbsc jlerbsc merged commit 5d36c8d into javaparser:master Dec 26, 2022
@jlerbsc
Copy link
Collaborator

jlerbsc commented Dec 26, 2022

Thank you for this contribution.

@jlerbsc jlerbsc added this to the Next release milestone Dec 26, 2022
@jlerbsc jlerbsc added the PR: Added A PR that introduces new behaviour (e.g. functionality, tests) label Dec 26, 2022
@mernst mernst deleted the nested-record branch December 27, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Added A PR that introduces new behaviour (e.g. functionality, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants