feat: Implement addRecord & getRecordByName for CompilationUnit #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marcluque Thank you for this suggestion but there is already an addType method. You can adapt the test cases and let the getRecordByName method. |
|
Hi @jlerbsc, thanks for the quick feedback! |
|
Thank you for your contribution. |
jlerbsc
added
the
PR: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
while working on a project, I noticed missing implementations for
getRecordByNameandaddRecord. I added their implementations and some simple tests for the implementations (similar to the existing ones for enum, etc.).Let me know if something could be improved or is missing.