Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the context of lexical preservation, the CSM token must be added m… #3874

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Jan 27, 2023

…anually only for new comments.
This is because comments are properties of nodes but they usually appear, lexically, outside the node. Since these new comments have no position, they cannot be placed by syntactic preversion. This is why it is necessary to manually add the tokens.

@jlerbsc jlerbsc merged commit adcdb6f into javaparser:master Jan 27, 2023
@jlerbsc jlerbsc added this to the next release milestone Jan 27, 2023
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant