Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 404: unicode whitespace and comments attribution #411

Merged
merged 6 commits into from Aug 16, 2016
Merged

Issue 404: unicode whitespace and comments attribution #411

merged 6 commits into from Aug 16, 2016

Conversation

matozoid
Copy link
Contributor

@matozoid matozoid commented Jul 29, 2016 •
edited

Solves #404

  • add unicode whitespace as whitespace tokens
  • Make sure we don't attribute multiple comments on the same line to a single node

@matozoid
* Add test
db672c9 
* Skip all unicode whitespace characters
@matozoid
* Make sure we don't attribute multiple comments on the same line to …
1483a1f 
…a single node
@matozoid
Merge branch 'master' into issue_404
187a536 
# Conflicts:
#	javaparser-testing/src/test/resources/com/github/javaparser/bdd/parsing_scenarios.story
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.053% when pulling 187a536 on matozoid:issue_404 into 8e44e1d on javaparser:master.

@ftomassetti ftomassetti mentioned this pull request Jul 29, 2016
Closed
@coveralls
Copy link

coveralls commented Aug 14, 2016 •
edited

Coverage Status

Changes Unknown when pulling 5e830a3 on matozoid:issue_404 into * on javaparser:master*.

@matozoid matozoid modified the milestones: next_release, 3.0.0 Aug 14, 2016
@matozoid matozoid merged commit 068b1c4 into javaparser:master Aug 16, 2016
@matozoid matozoid deleted the issue_404 branch August 16, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matozoid @coveralls