Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring: Simplifies how to group deleted tokens by extracting a method into an independent class #4134

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Aug 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4134 (e9103d7) into master (7f85786) will increase coverage by 0.058%.
The diff coverage is 79.227%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4134       +/-   ##
===============================================
+ Coverage     57.967%   58.025%   +0.058%     
  Complexity      2331      2331               
===============================================
  Files            642       644        +2     
  Lines          34454     34488       +34     
  Branches        5966      5968        +2     
===============================================
+ Hits           19972     20012       +40     
+ Misses         12339     12334        -5     
+ Partials        2143      2142        -1     
Flag Coverage Δ
AlsoSlowTests 58.025% <79.227%> (+0.058%) ⬆️
javaparser-core 50.469% <79.227%> (+0.085%) ⬆️
javaparser-symbol-solver 37.166% <0.000%> (-0.037%) ⬇️
jdk-10 58.014% <79.227%> (+0.058%) ⬆️
jdk-11 58.014% <79.227%> (+0.067%) ⬆️
jdk-12 58.008% <79.227%> (+0.058%) ⬆️
jdk-13 58.014% <79.227%> (+0.064%) ⬆️
jdk-14 58.011% <79.227%> (+0.055%) ⬆️
jdk-15 58.014% <79.227%> (+0.058%) ⬆️
jdk-16 57.988% <79.227%> (+0.061%) ⬆️
jdk-8 58.004% <79.227%> (+0.058%) ⬆️
jdk-9 58.014% <79.227%> (+0.058%) ⬆️
macos-latest 58.020% <79.227%> (+0.058%) ⬆️
ubuntu-latest 58.014% <79.227%> (+0.058%) ⬆️
windows-latest 58.008% <79.227%> (+0.067%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...parser/printer/concretesyntaxmodel/CsmElement.java 96.551% <0.000%> (ø)
...aparser/printer/concretesyntaxmodel/CsmIndent.java 71.428% <0.000%> (-28.572%) ⬇️
.../printer/lexicalpreservation/ChildTextElement.java 60.000% <ø> (ø)
.../printer/lexicalpreservation/TokenTextElement.java 91.176% <ø> (ø)
...r/printer/lexicalpreservation/PeekingIterator.java 52.830% <52.830%> (ø)
...parser/printer/lexicalpreservation/Difference.java 76.411% <66.666%> (-0.004%) ⬇️
...vaparser/printer/concretesyntaxmodel/CsmToken.java 87.500% <80.000%> (+14.772%) ⬆️
...alpreservation/ReshuffledDiffElementExtractor.java 94.214% <94.214%> (ø)
.../javaparser/printer/lexicalpreservation/Added.java 68.000% <100.000%> (ø)
...xicalpreservation/LexicalDifferenceCalculator.java 75.247% <100.000%> (+0.247%) ⬆️
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f85786...e9103d7. Read the comment docs.

@jlerbsc jlerbsc merged commit d087f19 into javaparser:master Aug 30, 2023
31 of 32 checks passed
@jlerbsc jlerbsc deleted the lookhead branch August 30, 2023 21:34
@jlerbsc jlerbsc added this to the next release milestone Aug 30, 2023
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant