Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue #3269 Test resources containing included interfaces do not compile #4139

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Sep 2, 2023

Fixes #3269 .

There are always compilation errors on test resources but this is probably mainly due to a trick to avoid creating multiple test resources.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #4139 (1e95dbc) into master (56cad2f) will decrease coverage by 0.024%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4139       +/-   ##
===============================================
- Coverage     58.013%   57.990%   -0.024%     
+ Complexity      2333      2330        -3     
===============================================
  Files            644       644               
  Lines          34509     34509               
  Branches        5974      5974               
===============================================
- Hits           20020     20012        -8     
- Misses         12344     12351        +7     
- Partials        2145      2146        +1     
Flag Coverage Δ
AlsoSlowTests 57.990% <ø> (-0.024%) ⬇️
javaparser-core 50.465% <ø> (ø)
javaparser-symbol-solver 37.138% <ø> (-0.024%) ⬇️
jdk-10 57.973% <ø> (-0.021%) ⬇️
jdk-11 57.979% <ø> (-0.021%) ⬇️
jdk-12 57.973% <ø> (-0.021%) ⬇️
jdk-13 57.979% <ø> (-0.024%) ⬇️
jdk-14 57.979% <ø> (-0.024%) ⬇️
jdk-15 57.973% <ø> (-0.027%) ⬇️
jdk-16 57.953% <ø> (-0.018%) ⬇️
jdk-8 57.975% <ø> (-0.024%) ⬇️
jdk-9 57.979% <ø> (-0.024%) ⬇️
macos-latest 57.984% <ø> (-0.024%) ⬇️
ubuntu-latest 57.979% <ø> (-0.024%) ⬇️
windows-latest 57.973% <ø> (-0.024%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cad2f...1e95dbc. Read the comment docs.

@jlerbsc jlerbsc merged commit bd42383 into javaparser:master Sep 2, 2023
32 checks passed
@jlerbsc jlerbsc added this to the next release milestone Sep 2, 2023
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test resources containing included interfaces do not compile
1 participant