Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue #2751 new HashSet()" != "new HashSet<>() #4183

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix: issue #2751 new HashSet()" != "new HashSet<>() #4183

merged 1 commit into from
Oct 29, 2023

Conversation

lcbarcellos
Copy link
Contributor

Change XML generator so that an empty type argument list is emmitted as an empty XML element. All other empty lists keep not being emmitted.

Fixes #2751 - Generated XML does not distinguish "new HashSet()" from "new HashSet<>()"

@lcbarcellos
Fix: issue javaparser#2751 new HashSet()" != "new HashSet<>()
a0e4072 
Change XML generator so that an empty type argument list is
emmitted as an empty XML element. All other empty lists
keep not being emmitted.
@jlerbsc
Copy link
Collaborator

jlerbsc commented Oct 29, 2023

This fix seems reasonable to me.

@jlerbsc jlerbsc merged commit 4249ae0 into javaparser:master Oct 29, 2023
30 of 32 checks passed
@jlerbsc jlerbsc added this to the next release milestone Oct 29, 2023
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Milestone
3.25.6
Development

Successfully merging this pull request may close these issues.

Generated XML does not distinguish "new HashSet()" from "new HashSet<>()"
2 participants
@lcbarcellos @jlerbsc