Fix: issue #4047 Symbol Solver mixes name with type

[jlerbsc]

Fixes #4047 .

When the scope of the method invocation is a NameExpr there was a specific type resolution that appears to take static methods into account. However, static methods are already taken into consideration. This code snippet that was removed has been there since the start of the project but may no longer be useful now. Still, this snippet raises a problem in certain cases where the scope is a variable declared in the method block and if the name of the variable also corresponds to a type. In this case it is the type of the variable which should make it possible to determine the declaration of the method.

[codecov]

Codecov Report

Merging #4206 (50cbb28) into master (15a9427) will decrease coverage by 0.007%.
The diff coverage is 100.000%.

Additional details and impacted files

@@               Coverage Diff               @@
##              master     #4206       +/-   ##
===============================================
- Coverage     57.996%   57.990%   -0.007%     
+ Complexity      2334      2330        -4     
===============================================
  Files            645       645               
  Lines          34578     34573        -5     
  Branches        5976      5974        -2     
===============================================
- Hits           20054     20049        -5     
  Misses         12366     12366               
  Partials        2158      2158               

Flag	Coverage Δ
AlsoSlowTests	57.990% <100.000%> (-0.007%)	⬇️
javaparser-core	50.529% <ø> (ø)
javaparser-symbol-solver	37.078% <100.000%> (-0.010%)	⬇️
jdk-10	57.978% <100.000%> (-0.004%)	⬇️
jdk-11	57.972% <100.000%> (-0.012%)	⬇️
jdk-12	57.978% <100.000%> (-0.007%)	⬇️
jdk-13	57.978% <100.000%> (-0.001%)	⬇️
jdk-14	57.978% <100.000%> (-0.007%)	⬇️
jdk-15	57.978% <100.000%> (-0.007%)	⬇️
jdk-16	57.946% <100.000%> (-0.007%)	⬇️
jdk-8	57.969% <100.000%> (-0.012%)	⬇️
jdk-9	57.978% <100.000%> (-0.007%)	⬇️
macos-latest	57.984% <100.000%> (-0.007%)	⬇️
ubuntu-latest	57.978% <100.000%> (-0.007%)	⬇️
windows-latest	57.972% <100.000%> (-0.007%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...arsermodel/contexts/AbstractJavaParserContext.java	77.966% <100.000%> (-0.083%)	⬇️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a9427...50cbb28. Read the comment docs.