Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Remove old comment that is no longer valid around jdks and add jdk 17 #4226

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

hazendaz
Copy link
Contributor

@hazendaz hazendaz commented Nov 25, 2023

No description provided.

@hazendaz hazendaz changed the title [GHA] Remove old comment that is no longer valid around jdks and add … [GHA] Remove old comment that is no longer valid around jdks and add jdk 17 Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #4226 (37c0bd2) into master (e245928) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #4226   +/-   ##
===========================================
  Coverage     57.995%   57.995%           
  Complexity      2330      2330           
===========================================
  Files            647       647           
  Lines          34577     34577           
  Branches        5974      5974           
===========================================
  Hits           20053     20053           
  Misses         12366     12366           
  Partials        2158      2158           
Flag Coverage Δ
AlsoSlowTests 57.995% <ø> (ø)
javaparser-core 50.537% <ø> (ø)
javaparser-symbol-solver 37.085% <ø> (ø)
jdk-10 57.980% <ø> (-0.003%) ⬇️
jdk-11 57.977% <ø> (-0.006%) ⬇️
jdk-12 57.977% <ø> (ø)
jdk-13 57.977% <ø> (-0.006%) ⬇️
jdk-14 57.977% <ø> (-0.006%) ⬇️
jdk-15 57.983% <ø> (ø)
jdk-16 57.957% <ø> (ø)
jdk-17 57.957% <ø> (?)
jdk-8 57.979% <ø> (ø)
jdk-9 57.983% <ø> (+0.002%) ⬆️
macos-latest 57.989% <ø> (ø)
ubuntu-latest 57.983% <ø> (+0.008%) ⬆️
windows-latest 57.977% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08ce98...37c0bd2. Read the comment docs.

@jlerbsc jlerbsc merged commit 80f4363 into javaparser:master Nov 26, 2023
35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Nov 26, 2023
@jlerbsc jlerbsc added the PR: Added A PR that introduces new behaviour (e.g. functionality, tests) label Nov 26, 2023
@hazendaz hazendaz deleted the jdk17 branch December 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Added A PR that introduces new behaviour (e.g. functionality, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants