Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Move cache features to javaparser-core #4238

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Refactoring: Move cache features to javaparser-core #4238

merged 1 commit into from
Nov 28, 2023

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Nov 28, 2023

No description provided.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #4238 (c6a0e51) into master (827f724) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              master     #4238     +/-   ##
=============================================
  Coverage     59.481%   59.481%             
- Complexity      2330      5700   +3370     
=============================================
  Files            647       647             
  Lines          34582     34582             
  Branches        5977      5977             
=============================================
  Hits           20570     20570             
  Misses         11410     11410             
  Partials        2602      2602             
Flag Coverage Δ
AlsoSlowTests 59.481% <ø> (ø)
javaparser-core 52.351% <ø> (-0.076%) ⬇️
javaparser-symbol-solver 37.097% <ø> (ø)
jdk-10 59.470% <ø> (+0.005%) ⬆️
jdk-11 59.470% <ø> (+0.005%) ⬆️
jdk-12 59.470% <ø> (+0.005%) ⬆️
jdk-13 59.470% <ø> (ø)
jdk-14 59.470% <ø> (ø)
jdk-15 59.464% <ø> (ø)
jdk-16 59.444% <ø> (+0.005%) ⬆️
jdk-17 59.444% <ø> (ø)
jdk-8 59.466% <ø> (+0.002%) ⬆️
jdk-9 59.467% <ø> (-0.003%) ⬇️
macos-latest 59.476% <ø> (ø)
ubuntu-latest 59.470% <ø> (ø)
windows-latest 59.464% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...github/javaparser/resolution/cache/GuavaCache.java 93.333% <ø> (ø)
...hub/javaparser/resolution/cache/InMemoryCache.java 100.000% <ø> (ø)
...om/github/javaparser/resolution/cache/NoCache.java 100.000% <ø> (ø)
...ver/resolution/typesolvers/CombinedTypeSolver.java 98.591% <ø> (ø)
...r/resolution/typesolvers/JavaParserTypeSolver.java 73.770% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827f724...c6a0e51. Read the comment docs.

@jlerbsc jlerbsc merged commit cbb82e8 into javaparser:master Nov 28, 2023
34 of 35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Nov 28, 2023
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant