Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring to use the existing getArgumentPosition method #4306

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Feb 2, 2024

Fix checkstyle issue
Removal of an unnecessary private method that searches for the position of an argument

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aadef00) 51.665% compared to head (c241695) 51.665%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4306   +/-   ##
=========================================
  Coverage   51.665%   51.665%           
=========================================
  Files          497       497           
  Lines        28288     28288           
  Branches      4895      4895           
=========================================
  Hits         14615     14615           
  Misses       11649     11649           
  Partials      2024      2024           
Flag Coverage Δ
AlsoSlowTests 51.665% <ø> (ø)
javaparser-core 51.665% <ø> (ø)
javaparser-symbol-solver 51.665% <ø> (ø)
jdk-10 51.661% <ø> (ø)
jdk-11 51.661% <ø> (ø)
jdk-12 51.661% <ø> (ø)
jdk-13 51.661% <ø> (ø)
jdk-14 51.661% <ø> (ø)
jdk-15 51.661% <ø> (ø)
jdk-16 51.661% <ø> (ø)
jdk-17 51.661% <ø> (ø)
jdk-18 51.661% <ø> (ø)
jdk-8 51.659% <ø> (ø)
jdk-9 51.661% <ø> (ø)
macos-latest 51.657% <ø> (ø)
ubuntu-latest 51.657% <ø> (ø)
windows-latest 51.643% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/com/github/javaparser/HasParentNode.java 90.909% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30dedd9...c241695. Read the comment docs.

@jlerbsc jlerbsc merged commit 6bc2332 into javaparser:master Feb 2, 2024
38 checks passed
@jlerbsc jlerbsc added this to the next release milestone Feb 2, 2024
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant