Fix crash on SwitchExpr entries if tokens are not stored #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4461 +/- ##
=============================================
- Coverage 52.003% 51.999% -0.004%
=============================================
Files 507 507
Lines 28654 28654
Branches 4969 4969
=============================================
- Hits 14901 14900 -1
- Misses 11684 11685 +1
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating SwitchExpr entries with an expression on the RHS, an ExpressionStmt is instantiated with the token range of the child Expression used as the token range for the ExpressionStmt. The problem is that this was not done safely, since
expr.getTokenRange()can be empty if thestoreTokensconfiguration option is disabled and in this case the parser would crash. This PR provides a safe alternative for this case, preventing the crash.This is an old bug that was most likely introduced with the original
SwitchExprsupport, but I missed it during my refactorings of the code.