Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Wickets way of dealing with metadata. Also copy their JavaDoc :-) #472

Merged
merged 4 commits into from
Sep 30, 2016
Merged

Copy Wickets way of dealing with metadata. Also copy their JavaDoc :-) #472

merged 4 commits into from
Sep 30, 2016

Conversation

matozoid
Copy link
Contributor

Fixes issue #456

I'll ask what the Wicket guys think of this :D

assertThat(node.getMetaData(DING)).isNull();
}

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at the end of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at the end of the file...

@matozoid
Copy link
Contributor Author

I think it looks very pretty. Thanks for the hint, @ptitjes !

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 63.29% when pulling b8f2708 on matozoid:issue_456_data_field into 1158a08 on javaparser:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 63.29% when pulling b8f2708 on matozoid:issue_456_data_field into 1158a08 on javaparser:master.

@martin-g
Copy link

Hi,

I've been notified that you needed to copy some code from Apache Wicket for your needs.
Since Apache Wicket is ASL2 licenced you can do whatever you want with the source code without asking anyone!
If you want you can mention somewhere that your project has copied code from other projects. But this is not mandatory at all!

Good luck!

@ptitjes
Copy link
Contributor

ptitjes commented Sep 26, 2016

« Licenced to steal » ? :)

And BTW, I wasn't suggesting to copy but rather get inspired... The pattern in itself was well-known before Wicket makes use of it, as using an anonymous inner class is the only way to retrieve the type parameter at runtime. (Web-search for that.)

That said, IMHO the term 'data' would be a better fit than 'mata-data' here...

@matozoid
Copy link
Contributor Author

I understand, the decision to copy (most) was completely mine :) I especially like the Javadoc. Maybe I should take Jonathan Locke's name out though!

Will change to data.

@ptitjes
Copy link
Contributor

ptitjes commented Sep 26, 2016

Or 'userData', or something else that makes it clear it is intended for the only use of the user, without reading the docs...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 63.29% when pulling 4d2dd43 on matozoid:issue_456_data_field into 1158a08 on javaparser:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 61.464% when pulling a404539 on matozoid:issue_456_data_field into 95245a5 on javaparser:master.

@matozoid matozoid merged commit 42fb694 into javaparser:master Sep 30, 2016
@matozoid matozoid deleted the issue_456_data_field branch September 30, 2016 12:13
@matozoid matozoid added this to the next_release milestone Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants