-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Wickets way of dealing with metadata. Also copy their JavaDoc :-) #472
Conversation
assertThat(node.getMetaData(DING)).isNull(); | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline at the end of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline at the end of the file...
I think it looks very pretty. Thanks for the hint, @ptitjes ! |
Hi, I've been notified that you needed to copy some code from Apache Wicket for your needs. Good luck! |
« Licenced to steal » ? :) And BTW, I wasn't suggesting to copy but rather get inspired... The pattern in itself was well-known before Wicket makes use of it, as using an anonymous inner class is the only way to retrieve the type parameter at runtime. (Web-search for that.) That said, IMHO the term 'data' would be a better fit than 'mata-data' here... |
I understand, the decision to copy (most) was completely mine :) I especially like the Javadoc. Maybe I should take Jonathan Locke's name out though! Will change to data. |
Or 'userData', or something else that makes it clear it is intended for the only use of the user, without reading the docs... |
…n't do anything with this data.
Fixes issue #456
I'll ask what the Wicket guys think of this :D