-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 866: LexicalPreservingPrinter: Unsupported operation - remove #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mergey merge merge? |
Rebased after merging #933 |
This was referenced May 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #866.
The PR is built on top of #929 and #930
We introduce a new CsmElement named CsmMix to represent elements that can have any order. They require a specific handling in Difference.apply. We basically considere the CsmMix before the change, after the change and the order of elements in the text trying to figure out the most natural way to change the text.
Additionally we need also to adapt space around in certain cases.
These three PRs combines should fix a few things in the lexical preservation. It is probably not 100% perfect but the number of tests is growing (203) and it should eventually stabilize. There are hard things related to indentation and space reconciliation.
In the long term I hope we root out all bugs, we grow our test base and then in 4.0 we can improve the whole design.