target node change class name

[LiadDrori]

Class Name should change when calling static methods

Expected Behavior

1. As the documentation says

Currently the output of browser and node is identical.

But there is a difference between them.

2. When a class name change it should change the class name in static method calls

Current Behavior

1. difference between the target node and browser
2. when calling static methods class name should also change

Steps to Reproduce

Code exmple:

class A { 
	static async one(){
    	
    }
  
  	static async two(){
    	await A.one()
    }

}

When using target=Brwoser:

class A {
    static async ['one']() {
    }
    static async ['two']() {
        await A['one']();
    }
}

When using target=node:

class _0xd91f5a {
    static async ['one']() {
    }
    static async ['two']() {
        await A['one']();
    }
}

When running with a target node you get error because A is not defined

Your Environment

• Obfuscator version used: 0.24.0
• Node version used: 12.4

[sanex3339]

Will try to fix soon

[LiadDrori]

Besides this, are there are any other differences between node and browser?
I run my code on node, so is it safe for now, until you fix the bug, to change to browser?

[sanex3339]

renameGlobals breaking this code too

[sanex3339]

@LiadDrori currently Node target should affect only how identifiers are renamed

[sanex3339]

Should sanitize class scopes like this:

// fast fix of class scopes
        scope.childScopes.filter((scope: eslintScope.Scope) => {
            if (scope.type === 'class') {
                const upperVariable: eslintScope.Variable = <any>scope.upper?.variables.find((variable: eslintScope.Variable) => {
                    return variable.name === scope.variables[0].name;
                });

                upperVariable.references.push(...scope.variables[0].references);

                return false;
            }
        });

[sanex3339]

After this pr, here should be no difference between Node and Browser targets in terms of variable names.

[sanex3339]

Released as 0.24.1 please try it

[LiadDrori]

Seems to work for me to,

Thanks for the help!!!

[sanex3339]

Nice!