Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To increase performance and prevent possible runtime errors `transfor… #951

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

sanex3339
Copy link
Member

…mObjectKeysoption now completely ignores objects withCallExpression` nodes

…mObjectKeys` option now completely ignores objects with `CallExpression` nodes
…mObjectKeys` option now completely ignores objects with `NewExpression` nodes
@rodhoward
Copy link

I think you need to remove the "?." optional chaining as your using node v12 I think. You can probably simplify the isTrue function to simply false and still get the same behaviour.

@sanex3339
Copy link
Member Author

I think you need to remove the "?." optional chaining as your using node v12 I think. You can probably simplify the isTrue function to simply false and still get the same behaviour.

Yeah, just forgot to reset dev.ts file with dev tests

});

it('shouldn ignore object expression if it contains a call expression and the previous property value is object expression', () => {
assert.match(obfuscatedCode, regExp);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious but would it be easier to actually execute the obfuscated code rather than test via regExp? I guess you have to do both.. Its just regular expression is so hard to follow I'm definitely lost :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes i need to evaluate obfuscated code (to be sure that it runs fine), but in this cases i want to be sure that obfuscated code looks right, so - RegExp

@sanex3339 sanex3339 merged commit 985cb7e into master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants