Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static properties and methods #172

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Static properties and methods #172

merged 2 commits into from
Jun 21, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented May 9, 2020

No description provided.

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #17, it's 167 ⁉️

@cortizg
Copy link
Contributor Author

cortizg commented May 9, 2020

#172 replace #167

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está perfecta. O estoy ciego. Deberían coincidir las líneas, agregué 2 suggest.

```
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.


```js run
class Animal {
static planet = "Earth";

static planet = "Tierra";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static planet = "Tierra";
static planet = "Tierra";

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio merged commit 05f7589 into javascript-tutorial:master Jun 21, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants