Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical operators #181

Merged
merged 24 commits into from
Jan 24, 2021
Merged

Logical operators #181

merged 24 commits into from
Jan 24, 2021

Conversation

Dorin-David
Copy link
Contributor

Ho finito la revisione dell'articolo sui logical operators. C'erano un pochino di cosette da sistemare. Per favore controllare e fatemi sapere so mi sono perso qualcosa.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 22, 2021 13:28
@pasor1 pasor1 changed the title Article/11 logical operators Logical operators Jan 22, 2021
@pasor1 pasor1 self-assigned this Jan 22, 2021
@Dorin-David
Copy link
Contributor Author

@pasor1 Chiariscimi un dubbio cortesemente. Sto revisionando l'articolo sui loop, dove negli snippet con codici i commenti sono scritti in italiano; in questo articolo, pero', li ho lasciati in inglese. Come ci comportiamo a riguardo? Dovremmo farlo presente anche agli altri, non penso sia chiara la cosa...

@longo-andrea longo-andrea mentioned this pull request Jan 23, 2021
48 tasks
Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasor1 Chiariscimi un dubbio cortesemente. Sto revisionando l'articolo sui loop, dove negli snippet con codici i commenti sono scritti in italiano; in questo articolo, pero', li ho lasciati in inglese. Come ci comportiamo a riguardo? Dovremmo farlo presente anche agli altri, non penso sia chiara la cosa...

Come regola, negli esempi di codice traduciamo solo i commenti, non traduciamo il codice (variabili, funzioni, ecc...)

Scrivi una condizione `if` per controllare che `age` sia compresa tra `14` e `90` estremi inclusi.

"Inclusi" significa che `age` può valere anche `14` o `90`.
Scrivi una condizione `if` per controllare che `age` sia compresa tra `14` e `90` (inclusi: `age` può valere anche `14` o `90`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mi sembrava un po' più chiaro prima della correzione...

1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Dorin-David and others added 8 commits January 23, 2021 23:32
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David
Copy link
Contributor Author

/done

Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasor1 pasor1 merged commit f17f17e into javascript-tutorial:master Jan 24, 2021
@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

@Dorin-David Dorin-David deleted the article/11-logical-operators branch January 27, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants