Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property flags and descriptors #196

Merged
merged 6 commits into from
Feb 1, 2021
Merged

Property flags and descriptors #196

merged 6 commits into from
Feb 1, 2021

Conversation

longo-andrea
Copy link
Contributor

In questo articolo non è stato facile decidere cosa tenere in inglese e cosa tradurre in italiano

@javascript-translate-bot javascript-translate-bot requested a review from a team January 27, 2021 21:02
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 27, 2021
Open
@longo-andrea @Dorin-David
Apply suggestions from code review
ce13c67 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci sono alcune piccole modifiche e suggerimenti. Ottima traduzione, comunque!

longo-andrea and others added 3 commits January 29, 2021 20:50
@longo-andrea @Dorin-David
Apply suggestions from code review
7578a6b 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea @Dorin-David
Update 1-js/07-object-properties/01-property-descriptors/article.md
9d70d12 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea @Dorin-David
Update 1-js/07-object-properties/01-property-descriptors/article.md
900083d 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

pasor1
pasor1 approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un paio di note

1-js/07-object-properties/01-property-descriptors/article.md
@@ -120,21 +120,21 @@ user.name = "Pete"; // Error: Cannot assign to read only property 'name'
*/!*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci sarebbe il commento nel codice da tradurre, linea 119

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui non ho tradotto perché suppongo (ma non sono sicuro) che sia il messaggio di errore che ti appare.. e ho paura che traducendolo perda di senso, visto che poi non apparirà mai in italiano... però non ci metterei la mano sul fuoco, smentitemi se sto dicendo una cavolata

1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
@longo-andrea @pasor1
Apply suggestions from code review
5edd17b 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit a86fbfc into javascript-tutorial:master Feb 1, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/property-descriptors branch February 7, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David left review comments

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longo-andrea @javascript-translate-bot @pasor1 @Dorin-David