Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the mouse: mouseover/out, mouseenter/leave #232

Conversation

pierangelomiceli
Copy link
Contributor

No description provided.

Copy link
Contributor

@longo-andrea longo-andrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierangelomiceli ti ho lasciato un paio di commenti, parecchi sono riguardo il termine "il tooltip" che io sono abituato a chiamare "la tooltip", comunque parliamone, in caso puoi ignorarli... un'altra cosa che manca è la traduzione dei commenti nel file script.js.. il resto tutto okay 👍

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pierangelomiceli and others added 9 commits February 26, 2021 22:49
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
…-mouseleave/article.md

Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un po' di correzioni, da rompiballe quale sono :-D

// if it's less than sensivity, then the speed is slow
// dopo ogni mousemove controlliamo la distanza
// tra le coordinate attuali e le precedenti
// se e' minore della "sensibilita'", allora la velocita' sara' bassa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// se e' minore della "sensibilita'", allora la velocita' sara' bassa
// se e' minore della "sensibilità", allora la velocità sarà bassa

@@ -76,7 +76,7 @@ class HoverIntent {
let speed;

if (!this.lastTime || this.lastTime == this.prevTime) {
// cursor didn't move
// il cursore non si e' mosso
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// il cursore non si e' mosso
// il cursore non si è mosso

pasor1 added 15 commits March 2, 2021 18:46
…-mouseleave/2-hoverintent/solution.view/hoverIntent.js
…-mouseleave/2-hoverintent/source.view/hoverIntent.js
…-mouseleave/2-hoverintent/source.view/hoverIntent.js
…-mouseleave/2-hoverintent/source.view/hoverIntent.js
…-mouseleave/mouseenter-mouseleave-delegation-2.view/script.js
@pasor1 pasor1 added the invalid This doesn't seem right label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right needs +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants