Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popups and window methods #269

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Popups and window methods #269

merged 3 commits into from
Mar 28, 2021

Conversation

longo-andrea
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 21, 2021 15:20
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 21, 2021
Open
pasor1
pasor1 requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corretto qualche "typo".
In molte situazioni ho suggerito "finestra popup" anziché "finestra di popup",
Idem per "il tab" al posto di "la tab" , ma qui si va un po' ad abitudine personale, anche se in genere i neologismi prendono il maschile.

3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea @pasor1
Apply suggestions from code review
0f55b61 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 26, 2021 20:10
@longo-andrea longo-andrea merged commit a65802b into javascript-tutorial:master Mar 28, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/popup-windows branch April 10, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasor1 pasor1 pasor1 requested changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longo-andrea @javascript-translate-bot @pasor1