Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns and flags #135

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Patterns and flags #135

merged 3 commits into from
Apr 20, 2021

Conversation

fixiabis
Copy link
Contributor

Target chapter

9-regular-expressions/01-regexp-introduction

Modified files

File name Change（reason）
article.md 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team April 12, 2021 08:46
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Apr 12, 2021
Open
lenchen1112
lenchen1112 approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts :)

lenchen1112
lenchen1112 requested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@fixiabis
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 14, 2021 10:26
lenchen1112
lenchen1112 approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @javascript-tutorial/translate-zh-hant anyone has concerns?

ArvinH
ArvinH reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ArvinH ArvinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @fixiabis thanks for the PR.
Have you signed the CLA?
https://cla-assistant.io/javascript-tutorial/zh-hant.javascript.info?pullRequest=135

@fixiabis
Copy link
Contributor Author

Just signed.

@lenchen1112 lenchen1112 merged commit 075e078 into javascript-tutorial:master Apr 20, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinH ArvinH ArvinH approved these changes

@lenchen1112 lenchen1112 lenchen1112 approved these changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fixiabis @CLAassistant @javascript-translate-bot @ArvinH @lenchen1112