Merge pull request #441 from ankitskvmdam/patch-1

fix: fillNa throws an error when values is an empty string
javascriptdata · Apr 15, 2022 · 0f85cae · 0f85cae
2 parents 2c274ee + 9b20ffa
commit 0f85cae
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/danfojs-base/core/frame.ts b/src/danfojs-base/core/frame.ts
@@ -2102,7 +2102,7 @@ export default class DataFrame extends NDframe implements DataFrameInterface {
     ): DataFrame | void {
         let { columns, inplace } = { inplace: false, ...options }
 
-        if (!values && typeof values !== "boolean" && typeof values !== "number") {
+        if (!values && typeof values !== "boolean" && typeof values !== "number" && typeof values !== "string") {
             throw Error('ParamError: value must be specified');
         }