Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

> https://danfo.jsdata.org/api-reference/general-functions/danfo.to_datetime #316

Closed
risenW opened this issue Nov 29, 2021 · 0 comments
Closed

> https://danfo.jsdata.org/api-reference/general-functions/danfo.to_datetime #316

risenW opened this issue Nov 29, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@risenW
Copy link
Member

risenW commented Nov 29, 2021

https://danfo.jsdata.org/api-reference/general-functions/danfo.to_datetime

Ahh, I see we forgot to update the correct type in https://github.com/opensource9ja/danfojs/blob/dev/danfojs-browser/types/index.d.ts

Would you be interested in updating this and sending a PR? A great simple issue to start contribution.

Originally posted by @risenW in #50 (comment)
@risenW risenW added the bug Something isn't working label Nov 29, 2021
kfern added a commit to kfern/danfojs that referenced this issue Nov 30, 2021
@kfern
Fix toDateTime type javascriptdata#316
430dadc
@kfern kfern mentioned this issue Nov 30, 2021
Closed
@risenW risenW mentioned this issue Dec 5, 2021
Merged
@risenW risenW closed this as completed Dec 5, 2021
@risenW risenW mentioned this issue Dec 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@risenW