Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fillNa throws an error when values is an empty string #441

Merged
merged 1 commit into from
Apr 15, 2022
Merged

fix: fillNa throws an error when values is an empty string #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/danfojs-base/core/frame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2102,7 +2102,7 @@ export default class DataFrame extends NDframe implements DataFrameInterface {
): DataFrame | void {
let { columns, inplace } = { inplace: false, ...options }

if (!values && typeof values !== "boolean" && typeof values !== "number") {
if (!values && typeof values !== "boolean" && typeof values !== "number" && typeof values !== "string") {
throw Error('ParamError: value must be specified');
}

Expand Down