Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

559 replace does not accept falsy strings or numbers #562

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

559 replace does not accept falsy strings or numbers #562

wants to merge 4 commits into from

Commits on Feb 23, 2023

  1. Added additonal tests for DataFrame.replace()

    @babennettdev
    babennettdev committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7200a40 View commit details
    Browse the repository at this point in the history

  2. Added additonal tests for Series.replace()

    @babennettdev
    babennettdev committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    2db945a View commit details
    Browse the repository at this point in the history

  3. Updating Series.replace() and DataFrame.replace() tests to expect err… 

    …or when oldValue is NaN
    @babennettdev
    babennettdev committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5e26647 View commit details
    Browse the repository at this point in the history

  4. Updated Series.replace() and DataFrame.replace() to handle falsy numb… 

    …ers (0), falsy strings (''), and throw when oldValue is NaN.
    @babennettdev
    babennettdev committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    6fa9cb8 View commit details
    Browse the repository at this point in the history