Add an explicit module info via moditect #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit
module-info.class
to the final artifact as a multi-release jar.This means Java 5 users will be unaffected, but those using Java 9+ will see the new file.
A stable module name, either automatic or this way, is needed for dependent libraries to add module-infos of their own. A real module-info is needed in every one of a user's dependencies for them to be able to use jlink.
Context for how I ended up here spring-projects/spring-framework#18079