Skip to content

Commit

Permalink
#1206 - Removed var usage
Browse files Browse the repository at this point in the history
  • Loading branch information
EdgarsGarsneks authored and bartoszwalacik committed Nov 12, 2023
1 parent dc7f663 commit 66c00e9
Showing 1 changed file with 18 additions and 15 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package org.javers.core.cases;

import org.javers.core.Changes;
import org.javers.core.Javers;
import org.javers.core.JaversBuilder;
import org.javers.core.diff.Diff;
import org.javers.core.diff.changetype.container.ArrayChange;
import org.javers.core.diff.changetype.container.ElementValueChange;
import org.junit.jupiter.api.Assertions;
Expand All @@ -9,7 +12,7 @@
import static org.junit.jupiter.api.Assertions.fail;

/**
* see https://github.com/javers/javers/issues/1206
* https://github.com/javers/javers/issues/1206
*
* @author Edgars Garsneks
*/
Expand All @@ -27,19 +30,19 @@ public BeanWithArray(String... items) {

@Test
public void shouldNotThrowNPEWhenSamplingNullRight() {
var a = new BeanWithArray("a");
var b = new BeanWithArray(new String[]{null});
BeanWithArray a = new BeanWithArray("a");
BeanWithArray b = new BeanWithArray(new String[]{null});

var javers = JaversBuilder.javers().build();
Javers javers = JaversBuilder.javers().build();

try {
var diff = javers.compare(a, b);
var changes = diff.getChanges();
Diff diff = javers.compare(a, b);
Changes changes = diff.getChanges();

Assertions.assertEquals(1, changes.size());

var change = (ArrayChange) changes.get(0);
var elementChange = (ElementValueChange) change.getChanges().get(0);
ArrayChange change = (ArrayChange) changes.get(0);
ElementValueChange elementChange = (ElementValueChange) change.getChanges().get(0);

Assertions.assertEquals(a.items[0], elementChange.getLeftValue());
Assertions.assertEquals(b.items[0], elementChange.getRightValue());
Expand All @@ -50,19 +53,19 @@ public void shouldNotThrowNPEWhenSamplingNullRight() {

@Test
public void shouldNotThrowNPEWhenSamplingNullLeft() {
var a = new BeanWithArray(new String[]{null});
var b = new BeanWithArray("a");
BeanWithArray a = new BeanWithArray(new String[]{null});
BeanWithArray b = new BeanWithArray("a");

var javers = JaversBuilder.javers().build();
Javers javers = JaversBuilder.javers().build();

try {
var diff = javers.compare(a, b);
var changes = diff.getChanges();
Diff diff = javers.compare(a, b);
Changes changes = diff.getChanges();

Assertions.assertEquals(1, changes.size());

var change = (ArrayChange) changes.get(0);
var elementChange = (ElementValueChange) change.getChanges().get(0);
ArrayChange change = (ArrayChange) changes.get(0);
ElementValueChange elementChange = (ElementValueChange) change.getChanges().get(0);

Assertions.assertEquals(a.items[0], elementChange.getLeftValue());
Assertions.assertEquals(b.items[0], elementChange.getRightValue());
Expand Down

0 comments on commit 66c00e9

Please sign in to comment.