-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MongoProperties is not used at all but it is required #1324
Labels
Comments
@fcanovas1986 thanks for reporting, you are right this property seems unused so the issue is easy to fix. Feel free to contribute a PR with the fix |
fcanovas1986
added a commit
to fcanovas1986/javers
that referenced
this issue
Sep 6, 2023
Hi @bartoszwalacik , could you review the opened PR? it is very little :) . Thanks! |
bartoszwalacik
pushed a commit
that referenced
this issue
Sep 15, 2023
thanks @fcanovas1986 , I will release it tomorrow |
fix was released in 7.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clear description of my expectations versus reality
Having configured the dependency
javers-spring-boot-starter-mongo
, when I run my application, I have the following error:That says that
JaversMongoAutoConfiguration
needs theMongoProperties
bean. I don't use this bean to set mongo settings, I think it should be optional. What's more, I checked that MongoProperties bean is autowired and it is required in JaversMongoAutoConfiguration, but it is not used at all, so you could even remove it. But if this is not the case for any reason, at least should be Optional.javers/javers-spring-boot-starter-mongo/src/main/java/org/javers/spring/boot/mongo/JaversMongoAutoConfiguration.java
Line 63 in b83fbd1
Steps To Reproduce
Configure the
javers-spring-boot-starter-mongo
and does not declare a MongoProperties bean in your application and run.Javers' Version
7.3.2
Additional context
The text was updated successfully, but these errors were encountered: