Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMapDotKeyReplacer throws an ConcurrentModificationException #910
Labels
Comments
This comment has been minimized.
This comment has been minimized.
Hi @luca010 , please provide a Runnable test case which isolates the bug and allows us to easily reproduce it on our laptops. You can push this test case to your fork of this repository. |
This comment has been minimized.
This comment has been minimized.
Hi @bartoszwalacik , I forked this repository and I added a new test case to reproduce the bug. I hope this will help you. |
This comment has been minimized.
This comment has been minimized.
Great, so now it shuld be easy for you to contribute the fix :) |
This comment has been minimized.
This comment has been minimized.
I pushed the fix on my fork. I run all the test cases with success. |
This comment has been minimized.
This comment has been minimized.
ok, please create the pull request from your fork to javers master |
This comment has been minimized.
This comment has been minimized.
fix is released in 5.8.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MapKeyDotReplacer throws an ConcurrentModificationException when tries to replace dots in the document Map. I would suggest to rewrite the method replaceInMapKeys in the MapKeyDotReplacer class as follows: