MapDotKeyReplacer throws an ConcurrentModificationException

[luca010]

MapKeyDotReplacer throws an ConcurrentModificationException when tries to replace dots in the document Map. I would suggest to rewrite the method replaceInMapKeys in the MapKeyDotReplacer class as follows:

private Document replaceInMapKeys(Document map, String regexFrom, String from, String to) {
    Document result = new Document();
    for (String key : map.keySet()) {
        Object val = map.get(key);
        if (key.contains(from)) {
            String escaped = key.replaceAll(regexFrom, to);
            result.put(escaped, val);
        } else {
           result.put(key, val);
        }
    }
    return result;
}

[bartoszwalacik]

Hi @luca010 , please provide a Runnable test case which isolates the bug and allows us to easily reproduce it on our laptops. You can push this test case to your fork of this repository.

[luca010]

Hi @bartoszwalacik , I forked this repository and I added a new test case to reproduce the bug. I hope this will help you.

[bartoszwalacik]

Great, so now it shuld be easy for you to contribute the fix :)

[luca010]

I pushed the fix on my fork. I run all the test cases with success.

[bartoszwalacik]

ok, please create the pull request from your fork to javers master

[bartoszwalacik]

fix is released in 5.8.5
@luca010 thanks for your contribution, well done