Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow multi edge #803

Closed
wants to merge 4 commits into from
Closed

Conversation

FmeuMan
Copy link
Contributor

@FmeuMan FmeuMan commented Mar 12, 2019

Should do the work for #528.
Dont know if is it worth it to handle collections with both entities and shallow entities. This doesn't work for now.

@bartoszwalacik
Copy link
Member

Hi @FmeuMan, nice PR but needs some work.
I have committed a failing test here #805

looks like we need to add support for class-level @ShallowReferecne:

The case:

class SnapshotEntity {
    Set<ShallowPhone> shallowPhones
}

@ShallowReference
public class ShallowPhone {
}

@FmeuMan
Copy link
Contributor Author

FmeuMan commented Mar 14, 2019

Nice one! I'll take a look.
And thanks for the reformating :)

@FmeuMan
Copy link
Contributor Author

FmeuMan commented Mar 14, 2019

Ok! Thoses additions seems a bit intrusive to me. But I don't think i can do better for now

@bartoszwalacik
Copy link
Member

@FmeuMan I have added more test on my branch, also I did some refactoring to make this new feature more aligned with javers-core. My branch is merged and I will release it tomorrow.
So I'm closing this branch, and finally, your last commit won't be merged.

Thanks for your contribution, you have great understanding of Javers code base and tests. Your PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants