Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed entities path bug of the connection in the dev mode #47

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

mberneti
Copy link
Contributor

related to this issue #37

@javieraviles
Copy link
Owner

I really like this idea, is simple but never bothered to automate it... was causing some pain though, so I'm glad you made it.

One point here is; why the Function part in line 11? I might be overlooking it but can't understand why is there? I'm not proficient in Typescript either :)

Second point: will move the base branch for the PR to develop

Third and last one: as you already created a const to establish whether is dev mode or note, should we use it for debugLogging and dbsslconn?

Thanks again!

@javieraviles javieraviles changed the base branch from master to develop September 12, 2019 18:26
@javieraviles
Copy link
Owner

I added some modification and now works as expected, looks good now :)

@javieraviles javieraviles merged commit 3c62247 into javieraviles:develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants