New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger time #49

Merged

javieraviles merged 1 commit into javieraviles:develop from ejose19:master

Sep 12, 2019

Contributor

ejose19 commented Sep 6, 2019

Using getMilliseconds() is inappropriate because if the request takes over 999ms the result will be inaccurate.

Example:
Start: 12:00:00:576 (576 is taken)
End: 12:00:05:126 (126 is taken)

Result in current implementation: -450ms
Result in fix: 4550ms


          Fix logger time

Owner

javieraviles commented Sep 12, 2019

looks great, thanks for the contribution!

javieraviles changed the base branch from master to develop

September 12, 2019 19:27

javieraviles merged commit 65f71ff into javieraviles:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment