refactor: Use optional chain expressions

javierbrea · Aug 15, 2023 · 52c8912 · 52c8912
1 parent 84884af
commit 52c8912
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -4,7 +4,7 @@
     "es6": true
   },
   "parserOptions": { 
-    "ecmaVersion": "2018"
+    "ecmaVersion": 2022
   },
   "plugins": ["prettier"],
   "rules": {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - chore(deps): Update devDependencies
 - chore(deps): Use NodeJs 16.x, 18.x and 20.x in pipelines
 - refactor: Remove redundant double negation
+- refactor: Use optional chain expressions
 
 ### Added
 - chore: Handle concurrency in pipelines

diff --git a/src/helpers/cypress.js b/src/helpers/cypress.js
@@ -1,5 +1,5 @@
 function isHeaded(Cypress) {
-  return Cypress.browser && Cypress.browser.isHeaded;
+  return Cypress.browser?.isHeaded;
 }
 
 function testHasFailed(currentTest) {
@@ -55,22 +55,16 @@ function getTestConfig(test) {
   }
   // Cypress >9
   if (
-    test.ctx &&
-    test.ctx.test &&
-    test.ctx.test._testConfig &&
-    test.ctx.test._testConfig.testConfigList &&
-    test.ctx.test._testConfig.testConfigList[
-      test.ctx.test._testConfig.testConfigList.length - 1
-    ] &&
-    test.ctx.test._testConfig.testConfigList[test.ctx.test._testConfig.testConfigList.length - 1]
-      .overrides
+    test.ctx?.test?._testConfig?.testConfigList?.[
+      test.ctx?.test?._testConfig?.testConfigList?.length - 1
+    ]?.overrides
   ) {
     return test.ctx.test._testConfig.testConfigList[
       test.ctx.test._testConfig.testConfigList.length - 1
     ].overrides;
   }
   // Cypress >6.7
-  if (test.ctx && test.ctx.test && test.ctx.test._testConfig) {
+  if (test.ctx?.test?._testConfig) {
     return test.ctx.test._testConfig;
   }
   return {};