Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cypress 7.* to peerDependencies #285

Closed
jimfm opened this issue Apr 6, 2021 · 1 comment
Closed

Update Cypress 7.* to peerDependencies #285

jimfm opened this issue Apr 6, 2021 · 1 comment
Assignees
Labels
dependencies Upgrade or change dependencies
Milestone

Comments

@jimfm
Copy link

jimfm commented Apr 6, 2021

Is your feature request related to a problem? Please describe.
Hardcoded dependencies need to have 7.* added.

Describe the solution you'd like
Update peerDependency

Describe alternatives you've considered
n/a

Additional context
n/a

@jimfm jimfm changed the title Update Cypress 7.* to peerDepencies Update Cypress 7.* to peerDependencies Apr 6, 2021
@javierbrea javierbrea self-assigned this Apr 7, 2021
@javierbrea javierbrea added the dependencies Upgrade or change dependencies label Apr 7, 2021
@javierbrea javierbrea added this to To do in Open source issues via automation Apr 7, 2021
@javierbrea javierbrea added this to the v1.4.3 milestone Apr 7, 2021
@javierbrea javierbrea moved this from To do to In progress in Open source issues Apr 7, 2021
@javierbrea
Copy link
Owner

Hi @jimfm,

Thanks for advising about the new Cypress version! 🙂 The renovate bot is configured in the project, but it waits three days before updating any new version in order to ensure its stability.

Dependencies are intentionally hardcoded because the Cypress version in e2e tests has to be updated in order to check that the plugin continues working properly. Anyway, I have manually updated the dependency in the e2e tests and published a new release supporting v7.x.

Open source issues automation moved this from In progress to Done Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Upgrade or change dependencies
Projects
Development

No branches or pull requests

2 participants