Merge pull request #42 from javierbrea/release

Release 1.0.2

.travis.yml

@@ -1,2 +1,11 @@
 version: ~> 1.0
-import: javierbrea/nodejs-ci-cd-shared-config:.travis.yml@master
+import:
+- source: javierbrea/nodejs-ci-cd-shared-config:.travis.yml@master
+  mode: deep_merge_prepend
+
+jobs:
+  include:
+    - stage: windows test
+      os: windows
+      script:
+        - npm run test:ci

CHANGELOG.md

@@ -10,6 +10,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 ### Removed
 
+## [1.0.2] - 2020-10-18
+### Added
+- chore: Run tests on Windows OS in pipelines
+
+### Fixed
+- fix: Plugin was not working properly on Windows
+
 ## [1.0.1] - 2020-08-27
 ### Changed
 - chore: Update dependencies

jest.config.js

@@ -29,5 +29,5 @@ module.exports = {
 
   // The glob patterns Jest uses to detect test files
   testMatch: ["**/test/**/*.spec.js"],
-  // testMatch: ["**/test/src/rules/no-private.spec.js"],
+  // testMatch: ["**/test/src/rules/entry-point.spec.js"],
 };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-boundaries",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Eslint plugin checking architecture boundaries between elements",
   "keywords": [
     "eslint",
@@ -23,9 +23,7 @@
     "lint-staged": "lint-staged",
     "test": "jest",
     "test:coverage": "npm run test",
-    "test:ci": "npm run test",
-    "stryker:dev": "stryker run stryker.conf.local.js",
-    "stryker": "stryker run"
+    "test:ci": "npm run test"
   },
   "peerDependencies": {
     "eslint": "^6.0.0 || ^7.0.0"
@@ -35,17 +33,14 @@
     "globule": "1.3.2"
   },
   "devDependencies": {
-    "@stryker-mutator/core": "3.3.1",
-    "@stryker-mutator/javascript-mutator": "3.3.1",
-    "@stryker-mutator/jest-runner": "3.3.1",
     "coveralls": "3.0.9",
-    "eslint": "7.7.0",
-    "eslint-config-prettier": "6.11.0",
+    "eslint": "7.11.0",
+    "eslint-config-prettier": "6.12.0",
     "eslint-plugin-prettier": "3.1.4",
-    "husky": "4.2.5",
-    "jest": "26.4.2",
-    "lint-staged": "10.2.11",
-    "prettier": "2.0.5"
+    "husky": "4.3.0",
+    "jest": "26.5.3",
+    "lint-staged": "10.4.0",
+    "prettier": "2.1.2"
   },
   "lint-staged": {
     "src/**/*.js": "eslint",
@@ -57,6 +52,6 @@
     }
   },
   "engines": {
-    "node": "12.x || 13.x || 14.x"
+    "node": "12.x || 14.x"
   }
 }

sonar-project.properties

@@ -1,6 +1,6 @@
 sonar.organization=javierbrea
 sonar.projectKey=eslint-plugin-boundaries
-sonar.projectVersion=1.0.1
+sonar.projectVersion=1.0.2
 
 sonar.javascript.file.suffixes=.js
 sonar.sourceEncoding=UTF-8

src/helpers/paths.js

@@ -3,7 +3,8 @@ const globule = require("globule");
 
 const { IGNORE, ALIAS, TYPES } = require("../constants/settings");
 
-const PATH_SEP = "/";
+const CODE_PATH_SEP = "/";
+const PATH_SEP = path.sep;
 const NODE_MODULES = "node_modules";
 const INDEX = "index.js";
 
@@ -35,9 +36,9 @@ const isAlias = (relativeFilePath, settings) => !!getUsedAlias(relativeFilePath,
 
 const replaceAliasByAbsolutePath = (relativeFilePath, settings) => {
   const usedAlias = getUsedAlias(relativeFilePath, settings);
-  return relativeFilePath.replace(
-    usedAlias,
-    path.resolve(getBasePath(), settings[ALIAS][usedAlias])
+  return path.resolve(
+    getBasePath(),
+    relativeFilePath.replace(usedAlias, settings[ALIAS][usedAlias])
   );
 };
 
@@ -81,8 +82,8 @@ const isAliasToNodeModules = (dependencyPath, settings) => {
 
 const isLocalDependency = (dependencyPath, settings) => {
   return (
-    ((dependencyPath.indexOf(`..${PATH_SEP}`) === 0 ||
-      dependencyPath.indexOf(`.${PATH_SEP}`) === 0) &&
+    ((dependencyPath.indexOf(`..${CODE_PATH_SEP}`) === 0 ||
+      dependencyPath.indexOf(`.${CODE_PATH_SEP}`) === 0) &&
       dependencyPath.indexOf(NODE_MODULES) < 1) ||
     (isAlias(dependencyPath, settings) && !isAliasToNodeModules(dependencyPath, settings))
   );

test/src/helpers.js

@@ -1,17 +1,24 @@
 const path = require("path");
 const RuleTester = require("eslint").RuleTester;
 
-const relativeFilePath = (relativePath) => path.join("test", "fixtures", relativePath);
+const codeFilePath = (relativePath) => {
+  return ["test", "fixtures", relativePath].join("/");
+};
+
+const relativeFilePath = (relativePath) => {
+  return path.join("test", "fixtures", relativePath);
+};
 
-const absoluteFilePath = (relativePath) =>
-  path.resolve(process.cwd(), path.join("test", "fixtures", relativePath));
+const absoluteFilePath = (relativePath) => {
+  return path.resolve(process.cwd(), relativeFilePath(relativePath));
+};
 
 const settings = {
   "boundaries/types": ["components", "modules", "helpers"],
   "boundaries/alias": {
-    helpers: relativeFilePath("src/helpers"),
-    components: relativeFilePath("src/components"),
-    modules: relativeFilePath("src/modules"),
+    helpers: codeFilePath("src/helpers"),
+    components: codeFilePath("src/components"),
+    modules: codeFilePath("src/modules"),
   },
 };
 
@@ -31,4 +38,5 @@ module.exports = {
   createRuleTester,
   absoluteFilePath,
   relativeFilePath,
+  codeFilePath,
 };

test/src/rules/allowed-types.spec.js

@@ -1,6 +1,6 @@
 const { ALLOWED_TYPES: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, settings, relativeFilePath } = require("../helpers");
+const { createRuleTester, absoluteFilePath, settings, codeFilePath } = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -91,7 +91,7 @@ ruleTester.run(RULE, rule, {
       options,
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/helpers/helper-b/**/*.js")],
+        "boundaries/ignore": [codeFilePath("src/helpers/helper-b/**/*.js")],
       },
     },
     // Invalid options

test/src/rules/entry-point.spec.js

@@ -1,6 +1,12 @@
 const { ENTRY_POINT: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const {
+  createRuleTester,
+  absoluteFilePath,
+  relativeFilePath,
+  codeFilePath,
+  settings,
+} = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -45,7 +51,7 @@ ruleTester.run(RULE, rule, {
       options,
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/helpers/helper-b/**/*.js")],
+        "boundaries/ignore": [codeFilePath("src/helpers/helper-b/**/*.js")],
       },
     },
     // import index with default option

test/src/rules/no-external.spec.js

@@ -1,6 +1,6 @@
 const { NO_EXTERNAL: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const { createRuleTester, absoluteFilePath, codeFilePath, settings } = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -38,7 +38,7 @@ ruleTester.run(RULE, rule, {
       options,
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/components/component-a/**/*.js")],
+        "boundaries/ignore": [codeFilePath("src/components/component-a/**/*.js")],
       },
     },
     // Modules can import react-router-dom

test/src/rules/no-import-ignored.spec.js

@@ -1,6 +1,6 @@
 const { NO_IMPORT_IGNORED: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const { createRuleTester, absoluteFilePath, codeFilePath, settings } = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -9,7 +9,7 @@ const ERROR_MESSAGE = "Importing ignored files is not allowed";
 
 const customSettings = {
   ...settings,
-  "boundaries/ignore": [relativeFilePath("src/components/component-b/**/*.js")],
+  "boundaries/ignore": [codeFilePath("src/components/component-b/**/*.js")],
 };
 
 ruleTester.run(RULE, rule, {
@@ -26,7 +26,7 @@ ruleTester.run(RULE, rule, {
       code: "import ComponentB from 'components/component-b'",
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/components/**/*.js")],
+        "boundaries/ignore": [codeFilePath("src/components/**/*.js")],
       },
     },
     // Non ignored files can be imported

test/src/rules/no-import-not-recognized-types.spec.js

@@ -1,6 +1,6 @@
 const { NO_IMPORT_NOT_RECOGNIZED_TYPES: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const { createRuleTester, absoluteFilePath, codeFilePath, settings } = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -9,7 +9,7 @@ const ERROR_MESSAGE = "Importing not recognized elements is not allowed";
 
 const customSettings = {
   ...settings,
-  "boundaries/ignore": [relativeFilePath("src/components/component-b/**/*.js")],
+  "boundaries/ignore": [codeFilePath("src/components/component-b/**/*.js")],
 };
 
 ruleTester.run(RULE, rule, {
@@ -26,7 +26,7 @@ ruleTester.run(RULE, rule, {
       code: "import Foo from '../../foo'",
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/components/**/*.js")],
+        "boundaries/ignore": [codeFilePath("src/components/**/*.js")],
       },
     },
     // Recognized types can be imported

test/src/rules/no-private.spec.js

@@ -1,6 +1,12 @@
 const { NO_PRIVATE: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const {
+  createRuleTester,
+  absoluteFilePath,
+  relativeFilePath,
+  codeFilePath,
+  settings,
+} = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -28,7 +34,7 @@ ruleTester.run(RULE, rule, {
       options,
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/components/component-a/ComponentA.js")],
+        "boundaries/ignore": [codeFilePath("src/components/component-a/ComponentA.js")],
       },
     },
     // Ignored dependencies can be imported
@@ -39,7 +45,7 @@ ruleTester.run(RULE, rule, {
       settings: {
         ...settings,
         "boundaries/ignore": [
-          relativeFilePath("src/components/component-a/components/component-c/**/*.js"),
+          codeFilePath("src/components/component-a/components/component-c/**/*.js"),
         ],
       },
     },

test/src/rules/prefer-recognized-types.spec.js

@@ -1,6 +1,6 @@
 const { PREFER_RECOGNIZED_TYPES: RULE } = require("../../../src/constants/rules");
 
-const { createRuleTester, absoluteFilePath, relativeFilePath, settings } = require("../helpers");
+const { createRuleTester, absoluteFilePath, codeFilePath, settings } = require("../helpers");
 
 const rule = require(`../../../src/rules/${RULE}`);
 const ruleTester = createRuleTester();
@@ -36,7 +36,7 @@ ruleTester.run(RULE, rule, {
       code: FOO_CODE,
       settings: {
         ...settings,
-        "boundaries/ignore": [relativeFilePath("src/foo/*.js")],
+        "boundaries/ignore": [codeFilePath("src/foo/*.js")],
       },
     },
   ],