fix: Fix report when dryRun option is enabled

javierbrea · Feb 14, 2022 · 0342dc1 · 0342dc1
1 parent 7313956
commit 0342dc1
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Removed
 ### Breaking changes
 
+## [Unreleased]
+
+### Fixed
+- fix: Fix report when dryRun option is enabled
+
 ## [1.0.0-beta.3]
 ### Fixed
 - fix: Use piexijs dump method to detect if file is really supported

diff --git a/src/assistant/setDateToFile.js b/src/assistant/setDateToFile.js
@@ -140,6 +140,8 @@ function SetDates({
         tracer.error(`${newFilePath}: Error writing Exif`, error.message);
         await handleUnresolved();
       }
+    } else {
+      report.modified(newFilePath, datesToSet, from);
     }
   };
 }

diff --git a/test/unit/assistant/setDate.spec.js b/test/unit/assistant/setDate.spec.js
@@ -538,7 +538,7 @@ describe("setDate", () => {
     });
   });
 
-  describe("when is not supported", () => {
+  describe("when it is not supported", () => {
     describe("when copyIfNotModified option is true", () => {
       it("should copy the file if outputFolder is not the same in which the file is", async () => {
         const spy = spyTracer("debug");
@@ -678,6 +678,32 @@ describe("setDate", () => {
         expect(result.totals.before.path).toEqual(result.totals.after.path);
       });
     });
+
+    describe("When dryRun option is provided", () => {
+      it("should only report modifications withour modifying original file", async () => {
+        const spy = spyTracer("debug");
+        const fileName = "gorilla.JPG";
+        const newFileName = "2013-10-23.jpg";
+        const date = "2013:10:23 00:00:00";
+        await copyAssetToTempPath(fileName, newFileName);
+        const fileOrigin = tempPath(newFileName);
+
+        const result = await setDate(fileOrigin, {
+          dryRun: true,
+        });
+
+        expectLog(
+          `2013-10-23.jpg: Setting DateTimeOriginal and DateTimeDigitized to 2013-10-23 00:00:00, from file name`,
+          spy
+        );
+        expect(result.totals.before.withDate).toEqual(0);
+        expect(result.totals.after.withDate).toEqual(1);
+        expect(result.totals.after.copied).toEqual(0);
+        expect(result.totals.after.moved).toEqual(0);
+        expect(result.totals.after.modified).toEqual(1);
+        expect(result.totals.before.path).toEqual(result.totals.after.path);
+      });
+    });
   });
 
   describe("when fileName is a valid partial date and baseDate is provided", () => {