Add windows compatibility. Upgrade lodash version

javierbrea · Nov 1, 2019 · 2e5fbcb · 2e5fbcb
1 parent 7de9580
commit 2e5fbcb
Show file tree

Hide file tree

Showing 5 changed files with 74 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -41,7 +41,7 @@
     "chalk": "^2.4.2",
     "fs-extra": "^7.0.1",
     "globule": "^1.2.1",
-    "lodash": "^4.17.11",
+    "lodash": "^4.17.15",
     "inquirer": "^6.2.2"
   },
   "devDependencies": {

diff --git a/src/npm.js b/src/npm.js
@@ -22,6 +22,7 @@ const install = retrying => {
     console.log("Reinstalling npm dependencies...");
     const installProcess = childProcess.spawn("npm", ["i"], {
       windowsHide: true,
+      shell: true,
       env: {
         ...process.env,
         FORCE_COLOR: true

diff --git a/src/utils/packages.js b/src/utils/packages.js
@@ -27,7 +27,7 @@ const packagesToMap = packagesInfo => {
   return packagesMap;
 };
 
-const packageFolder = packageJsonPath => packageJsonPath.split(path.sep)[0];
+const packageFolder = packageJsonPath => packageJsonPath.split("/")[0];
 
 const readAll = () => {
   return paths.getWorkingPath().then(workingPath => {

diff --git a/test/utils/packages.spec.js b/test/utils/packages.spec.js
@@ -160,7 +160,7 @@ describe("packages", () => {
       await packages.writePackageJson(fooFolder, fooPackage);
       const writeCall = fsExtra.writeJson.getCall(0);
       expect(writeCall.args[0]).toEqual(
-        expect.stringContaining("fixtures/foo-folder/package.json")
+        expect.stringContaining(["fixtures", "foo-folder", "package.json"].join(path.sep))
       );
       expect(writeCall.args[1]).toEqual(fooPackage);
     });