Add ruby 3.2.x support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable Width Allocation https://bugs.ruby-lang.org/issues/18239 changes the layout of strings in Ruby. The new layout for embedded strings: ``` /* 16 */ struct { /* 16 | 8 */ long len; /* 24 | 1 */ char ary[1]; /* XXX 7-byte padding */ /* total size (bytes): 16 */ } embed; ``` We need to account for the length, that was not present as its own field before. Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
javierhonduco
force-pushed
the
add-ruby-3-2-x-support
branch
from
3e496b1
to
f32d265
Compare
|
@manuelfelipe Happy to merge if you are happy with this. If you prefer to cut the PR that's totally fine too :) |
|
no need for the PR. feel free to merge whenever you are able to. Thanks again for the help and insights! |
|
Thanks!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.