forked from aircall/frontend-hiring-test
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ph0000/senior software engineer #1
Open
javierlopezdeancos
wants to merge
38
commits into
master
Choose a base branch
from
feat/ph0000/senior-software-engineer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,683
−927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Senior Software Engineer to Aircall Frontend Hiring Test
Add unit tests for the date helper functions.
Add some functions using jest to some date helpers use cases and some corner cases.
Fix the logout feature
Logout, delete all local storage information about tokens and return to login page. If user try to set directly in the URL search bar the calls URL again without having logged, then should be redirected to log in.
useAuth
that providelogin
,logout
andisAuth
methods to manage the state of the user and the user information in our app that we can use in each component. This hook is responsible to get the user info with theme
gql query in order to have this information persists when the user refreshes the browser but is already logged in.Fix the token expiration UX.
auth
service to build the Apollo client to handle all that logic.Take into account that we Are Not supported
graphql-ws
protocol on server then we usesubscriptions-transport-ws
to build our subscriptions to our websockets with Apollo.Add an end to end test for the feature of your choice
package.jon
with execution about e2e tasks.Implement the archive call feature and add real-time support.
page
folder splitting by domainLogin
,Calls
and bounded context.CallsList
component into split components with single responsibility that allow better maintenance and readability.onUpdatedCall
gql subscription.CallsList
andCallDetails
toonUpdatedCall
event from websocket in order to hear server updates about some call update.Screenshots