Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios problems #15

Closed
vip32 opened this issue Jan 31, 2014 · 9 comments
Closed

ios problems #15

vip32 opened this issue Jan 31, 2014 · 9 comments
Assignees
Labels

Comments

@vip32
Copy link

vip32 commented Jan 31, 2014

on ios (5+7) the rating does not work. stars are not clickable. on an ipad i can change some stars with lots of effort (not smooth). on an iphone no stars can be selected. very strange problem for such a great plugin.

on android/desktop all is working well.

@javiertoledo
Copy link
Owner

May be related to #13, but if I have time, I'll review it ;-)

@vip32
Copy link
Author

vip32 commented Feb 4, 2014

No hurry, switched to rateit for the meantime.
On Feb 2, 2014 10:15 PM, "Javier Toledo" notifications@github.com wrote:

May be related to #13#13,
but if I have time, I'll review it ;-)

Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-33912938
.

@ghost
Copy link

ghost commented Feb 8, 2014

Hi,

I just tested it on ios 7 and its working perfectly. The only improvement Javier is it somehow works a bit slower than on Windows Phone without any apparent reason. Basically when I click the star on Windows Phone it gets immediately selected. On iPhone it delays around 1sec before showing it selected.

Cheers and keep up the excelent work!

@vip32
Copy link
Author

vip32 commented Feb 8, 2014

Ipad or iphone?
On Feb 8, 2014 1:20 PM, "brunofalcao" notifications@github.com wrote:

Hi,

I just tested it on ios 7 and its working perfectly.

Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-34542562
.

@ghost
Copy link

ghost commented Feb 8, 2014

Hi vip32,

On my case it works at perfectly on both, iPad and iPhone ... :)

@hallerma
Copy link

I was not able to reproduce the problem with my ipod touch (ios 6.1) device.

Anyway, maybe someone with this problem can have a look at https://github.com/ftlabs/fastclick - it seems to solve a similar (the same?) problem.

@ghost
Copy link

ghost commented Apr 27, 2014

Hi hallerma,

True indeed. Fastclick fully disables this plugin to work, I confirm too.

@cstansbury
Copy link
Contributor

Note - I've fixed the fastclick incompatibility in this pull request.

@javiertoledo javiertoledo self-assigned this May 25, 2015
@javiertoledo
Copy link
Owner

Fixed in PR #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants