Skip to content

Commit

Permalink
fix: util.parseArgs() missing node:process import
Browse files Browse the repository at this point in the history
fix parseArgs() not working due to missing import of node:process

this commit fixes issue denoland#22363
  • Loading branch information
javihernant committed Feb 13, 2024
1 parent 6be389c commit 76cf06e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ext/node/polyfills/internal/util/parse_args/parse_args.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ const {
ERR_PARSE_ARGS_UNEXPECTED_POSITIONAL,
} = codes;

import process from "node:process";

function getMainArgs() {
// Work out where to slice process.argv for user supplied arguments.

Expand Down

1 comment on commit 76cf06e

@mmastrac
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can you try enabling the test:

      "test-parse-args.mjs",

By removing the ignored test in tests/node_compat/config.jsonc?

Please sign in to comment.