Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruler makes links unclickable on some pages #18

Closed
selfthinker opened this issue Feb 1, 2019 · 3 comments
Closed

Ruler makes links unclickable on some pages #18

selfthinker opened this issue Feb 1, 2019 · 3 comments

Comments

@selfthinker
Copy link

The ruler makes links unclickable on some pages because it overlaps the text and links closer to where the pointer is.
Example site where this is happening: https://alphagov.github.io/accessibility-personas/simone/

I suspect this happens because the ruler height is set in em while the top position is set in px.
I have fixed this locally by adding a max-height: 20px; but the better fix would be to make the JS for the top position aware of the em size and reposition itself accordingly. Or make the ruler height use px. Although that would mean it wouldn't fit the height of the text correctly, you could also re-calculate the em into px to fix that.
selfthinker added a commit to alphagov/accessibility-personas that referenced this issue Feb 1, 2019
@selfthinker
Fix unclickable links with Simone's extension
3c5759d 
The "Dyslexia Friendly" Chrome extension creates a ruler on the page
which overlaps the text on some pages like ours so that links cannot be clicked on.
This makes the ruler a bit smaller so links work again.

Reported and can be removed again after this has been fixed:
javoire/dyslexia-friendly#18
@selfthinker
Copy link
Author

I will deploy a hack to fix this on that example site next week, so you won't experience it happening there after that. Unless you temporarily disable that hack via the browser's inspector.

@javoire
Copy link
Owner

javoire commented Feb 9, 2019

Hi, thanks for your feedback! That's indeed a silly bug, thx for finding it, I made a fix here #19, hoping to ship it in a few days.

Cheers!

@javoire javoire mentioned this issue Feb 9, 2019
Closed
@javoire
Copy link
Owner

javoire commented Mar 31, 2019 •
edited
Loading

fixed at https://github.com/javoire/dyslexia-friendly/blob/master/src/css/contentscript.css#L79

A new version has been released in Chrome Web Store

@javoire javoire closed this as completed Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm pointer event from ruler to prevent it from stopping clicks etc javoire/dyslexia-friendly
2 participants
@selfthinker @javoire