Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models with string typed primary keys violates integer field in the hooks #128

Closed
javrasya opened this issue Jan 28, 2020 · 0 comments
Closed
Assignees
Labels
bug
Milestone

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Jan 28, 2020

Description:

As @xuziheng1002 has reported in issue #127;
Since the object id fields in the hook model classes are positive integer field, it is impossible to have models with string primary key field.

Acceptance Criteria:

  • It should be Charfield instead of PositiveIntegerField as it is in Transition and TransitionApproval.
  • Prepare a migration script that would safely migrate the existing object id's to its string values.
@javrasya javrasya self-assigned this Jan 28, 2020
@javrasya javrasya added the bug label Jan 28, 2020
@javrasya javrasya added this to the 3.1.1 milestone Jan 28, 2020
javrasya added a commit that referenced this issue Jan 28, 2020
javrasya added a commit that referenced this issue Jan 28, 2020
…ation (#130)
@javrasya javrasya closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.