Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Microsoft SQL Server #141

Closed
javrasya opened this issue Feb 18, 2020 · 0 comments
Closed

Support Microsoft SQL Server #141

javrasya opened this issue Feb 18, 2020 · 0 comments
Assignees
@javrasya
Labels
enhancement
Milestone
3.2.0

Comments

@javrasya
Copy link
Owner

javrasya commented Feb 18, 2020 •
edited

Description:

The way how django-river finds what is on approval is that it is using a library that is called django-cte which allows us to do some more advanced queries like windowing, joining two datasets, etc. It doesn't work with Microsoft SQL Database

Acceptance Criteria:

  • Maybe implement a custom SQL scripts instead of using cte but to do the same thing. Different SQL script can be used with different DB drivers.
@javrasya javrasya mentioned this issue Feb 18, 2020
Closed
@javrasya javrasya changed the title Support Microsoft SQL Database Support Microsoft SQL Server Feb 18, 2020
javrasya added a commit that referenced this issue Feb 18, 2020
@javrasya
[#141] Setup testing for Microsoft SQL Server
464e8c8
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Introduce river driver to handle incompatible parts differentl…
f20ac41 
…y per db backend
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Find available approvals by running a sql instead of doing it …
d5597e8 
…orm fashion to support MSSQL
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Run tests on travis
7ee1079
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Run all tests instead of only MSSQL ones
e426cde
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Test MSSQL 19 support
4c4b833
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Use MSSQL 19 image instead of 17 image wrongly
8ce8f20
javrasya added a commit that referenced this issue Mar 16, 2020
@javrasya
[#141] Install MSSQl dependencies only for the related tasks
843a6a0
javrasya added a commit that referenced this issue Mar 17, 2020
@javrasya
[#141] Improve the code quality
3148738
javrasya added a commit that referenced this issue Mar 17, 2020
@javrasya
[#141 , #143] Support Microsoft SQL Server 17 and 19
5b71699 
* [#141] Support Microsoft SQL Server 17 and 19
javrasya added a commit that referenced this issue Mar 17, 2020
@javrasya
[#141] Update changelogs with the release changes
d26645d
@javrasya javrasya added this to the 3.2.0 milestone Mar 17, 2020
@javrasya javrasya self-assigned this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javrasya javrasya

Labels
enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@javrasya